KEMBAR78
gh-108113: Make it possible to create an optimized AST by iritkatriel · Pull Request #108154 · python/cpython · GitHub
Skip to content

gh-108113: Make it possible to create an optimized AST #108154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 21, 2023
Merged

gh-108113: Make it possible to create an optimized AST #108154

merged 10 commits into from
Aug 21, 2023

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 19, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 19, 2023
Closed
@iritkatriel iritkatriel requested a review from carljm August 19, 2023 21:54
corona10
corona10 reviewed Aug 20, 2023
View reviewed changes
corona10
corona10 reviewed Aug 20, 2023
View reviewed changes
iritkatriel and others added 2 commits August 21, 2023 10:06
@iritkatriel
make patchcheck
b6d49a8
@iritkatriel @corona10
Update Doc/whatsnew/3.13.rst
1070d01 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
carljm
carljm reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a docs build issue, but otherwise this LGTM.

@iritkatriel iritkatriel enabled auto-merge (squash) August 21, 2023 15:49
@iritkatriel iritkatriel merged commit 10a91d7 into python:main Aug 21, 2023
@carljm carljm mentioned this pull request Dec 17, 2023
Closed
@dreamflow
Copy link
Contributor

should the new ast.PyCF_OPTIMIZED_AST
be mentioned in the compiler-flags doc ?

the compile() doc has a link to the compiler-flags doc ,
so that someone reading the compile() doc , can find out
that compile() has the ast.PyCF_OPTIMIZED_AST option .

@iritkatriel
Copy link
Member Author

@dreamflow Would you like to create a PR for that doc change?

@dreamflow dreamflow mentioned this pull request Dec 18, 2023
Merged
@dreamflow
Copy link
Contributor

@iritkatriel yes , i'm happy to 🙂

have posted the PR #113241

@iritkatriel iritkatriel mentioned this pull request Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm left review comments

@corona10 corona10 corona10 approved these changes

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

compile() with PyCF_ONLY_AST flag ignores the optimize arg

5 participants

@iritkatriel @dreamflow @carljm @corona10 @bedevere-bot