gh-109870: Combine exec calls in dataclass #110186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We return tuple of name, txt, and locals for each fn. I added including a striped fn name (no `__`) so that dataclass_return_type can be unique for each fn. Modified the exec section to join the locals back together, and call them all under one __create_fn__
Don't need globals for each now. Wait to call _recursive_repr on _repr_fn until later
You may want to do something different here. Essentially I ended up inlining the logic (similar to how you do order defs), since we won't be calling the completed fn like before.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
When I have more time this coming week I’ll figure out how to run test_dataclasses.py locally and see if/what I’ve messed up. |
|
Closing this as @ericvsmith has a much better refactored version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the gh issue, this is my attempt to combine the various exec calls (init, repr, eq, etc) into one, resulting in a increasing speedup with each additional exec call avoided. Around 1.1-1.22 speedup.
I don't expect this to be taken as-is. Mainly wanted to get something up so @ericvsmith has something cleaned up to look at.