gh-112451: Make C-extension datetime.timezone acceptable as a base class. #112518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think there is a need to override the default allocator. cc. @pganssle |
|
Rebased, in case it helps 😄 |
| class MyTimezone(_datetime.timezone): | ||
| pass | ||
|
|
||
| self.assertIs(issubclass(MyTimezone, _datetime.timezone), True) |
There was a problem hiding this comment.
Test that MyTimezone(...) returns a MyTimezone instance.
There was a problem hiding this comment.
It's not 😞 Thanks for finding this 🎯
|
Closing per discussion in #112451. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we implement
tp_allocfordatetime.timezone? 🤔 Can do if it's required.datetime.timezoneis not acceptable as a base class; pure-Python version is #112451