GH-118289: Fix handling of non-directories in os.path.realpath()
#118290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In strict mode, raise `NotADirectoryError` if a file path is given with a trailing slash, or subsequent dot segments. We use a `part_count` variable rather than `len(rest)` because the `rest` stack also contains markers for unresolved symlinks.
`NotADirectoryError` was already raised. This reverts commit 3390dbc.
eryksun
reviewed
May 29, 2024
eryksun
reviewed
May 29, 2024
Co-authored-by: Eryk Sun <eryksun@gmail.com>
eryksun
reviewed
May 29, 2024
* Add docs for new APIs * Add soft-deprecation notices * Add What's New porting entries * Update comments referencing `PyFrame_LocalsToFast()` to mention the proxy instead * Other related cleanups found when looking for refs to the deprecated APIs
* Clarify impact on default behaviour of exec, eval, etc * Update documentation for changes to PyEval_GetLocals (pythongh-74929) Closes pythongh-11888
….20240524 in /Tools (python#119899)
Only call `gc_restore_tid()` from stop-the-world contexts. `worklist_pop()` can be called while other threads are running, so use a relaxed atomic to modify `ob_tid`.
|
Did |
hugovk
removed request for
a team,
1st1,
AlexWaygood,
FFY00,
JelleZijlstra,
abalkin,
ambv,
asvetlov,
brettcannon,
ericsnowcurrently,
ezio-melotti,
gvanrossum,
hugovk,
iritkatriel,
jaraco,
kumaraditya303,
lysnikolaou,
markshannon,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
serhiy-storchaka,
vsajip,
warsaw and
willingc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
37 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In strict mode, raise
NotADirectoryErrorif we encounter a non-directory while we still have path parts left to process.We use a
part_countvariable rather thanlen(rest)because thereststack also contains markers for unresolved symlinks.os.path.realpath('notadir/', strict=True)doesn't raise #118289