KEMBAR78
[3.12] gh-101137: Add `text/x-rst` to `mimetypes` (GH-118593) by sobolevn · Pull Request #118599 · python/cpython · GitHub
Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented May 5, 2024

(cherry picked from commit 1511bc9)

@sobolevn sobolevn requested a review from jaraco May 5, 2024 15:49
@sobolevn sobolevn requested a review from a team as a code owner May 5, 2024 15:49
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on merging this until there's a decision on #118594 (and only include this backport if markdown is backported and there's no objection to merging this one).

@bedevere-app
Copy link

bedevere-app bot commented May 5, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@hugovk
Copy link
Member

hugovk commented Nov 10, 2024

Let's hold off on merging this until there's a decision on #118594 (and only include this backport if markdown is backported and there's no objection to merging this one).

That was merged, albeit with a post-merge objection: #118594 (comment)

Maybe close this backport?

@jaraco
Copy link
Member

jaraco commented Nov 10, 2024

Let's hold off on merging this until there's a decision on #118594 (and only include this backport if markdown is backported and there's no objection to merging this one).

That was merged, albeit with a post-merge objection: #118594 (comment)

Maybe close this backport?

I wouldn't characterize that as a post-merge objection, more an objection about the process than the change itself. Since the markdown change was backported and not reverted, it seems prudent to also backport the rst change, as those two changes were symmetrical. I advocate to merge this change.

@ambv ambv merged commit b41e008 into python:3.12 Apr 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants