KEMBAR78
gh-122781: fix time format bug by midnightstardust · Pull Request #122829 · python/cpython · GitHub
Skip to content

Conversation

@midnightstardust
Copy link

@midnightstardust midnightstardust commented Aug 8, 2024

Fixed it such that %z is now read as optional and can be an empty string.

@bedevere-app
Copy link

bedevere-app bot commented Aug 8, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@@ -0,0 +1 @@
Make %z represent an optional UTC offset instead of mandating a UTC offset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate NEWS

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests and remove the duplicate NEWS entry.

I have proposed a simpler approach in: #132922

@donBarbos
Copy link
Contributor

@StanFromIreland apparently you can now close this PR since the issue has been resolved

@StanFromIreland
Copy link
Member

Thank you, yes this was fixed with #132922.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants