GH-119518: Stop interning strings in pathlib #123356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `sys.intern(str(x))` calls when normalizing a path in pathlib. This
speeds up `str(Path('foo/bar'))` by about 10%.
vstinner
reviewed
Aug 28, 2024
|
Thank you both! |
|
Can this be back ported to 3.13? The interning causes memory usage to grow indefinitely on a free threaded build. |
IMO it's too late to backport such change. cc @colesbury |
|
Maybe we could consider something like the following in 3.13: if sysconfig.get_config_var("Py_GIL_DISABLED"):
return drv, root, [x for x in rel.split(sep) if x and x != '.']
parsed = [sys.intern(str(x)) for x in rel.split(sep) if x and x != '.']
return drv, root, parsedIn other words, avoid interning in the free-threaded build, but don't change the behavior in the 3.13 default build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
sys.intern(str(x))calls when normalizing a path in pathlib. This speeds upstr(Path('foo/bar'))by about 10%.As mentioned in the issue, I've never been able to establish if/when string interning is useful in pathlib, nor that we're using it in the best way. It feels negligent to leave it in the code.