[3.13] gh-124442: make __static_attributes__ deterministic by sorting (GH-124492)
#124738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sorting (pythonGH-124492) (cherry picked from commit 04c837d) Co-authored-by: Kira <kp2pml30@gmail.com> Signed-off-by: kp2pml30 <kp2pml30@gmail.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
JelleZijlstra
requested review from
iritkatriel and
markshannon
as code owners
This was referenced Sep 28, 2024
|
@Yhg1s it's probably good to get this into the next RC. We can do it later too (#124442 (comment)), but would be nicer to get this right the first time. |
Yhg1s
reviewed
Sep 30, 2024
JelleZijlstra
commented
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 04c837d)
__static_attributes__is not deterministic #124442