gh-129027: Raise DeprecationWarning for sys._clear_type_cache #129043

srinivasreddy · 2025-01-20T06:38:47Z

Issue: Raise DeprecationWarning for sys._clear_type_cache #129027

Lib/test/test_sys.py

tomasr8

sys._clear_type_cache is used in other tests as well which will now raise a DeprecationWarning. I think we should suppress the warnings in the relevant tests (or maybe switch to sys._clear_internal_caches()? though that might make backporting tests to 3.12 more difficult since the function was added in 3.13)

Python/sysmodule.c

tomasr8 · 2025-01-20T17:03:36Z

This will also require a news entry :)

srinivasreddy · 2025-01-21T06:22:17Z

@tomasr8 Addressed in c532328

Lib/test/test_sys.py

Lib/test/test_type_cache.py

Python/sysmodule.c

Misc/NEWS.d/next/Library/2025-01-21-11-48-19.gh-issue-129027.w0vxzZ.rst

Python/sysmodule.c

tomasr8

Would you also like to add a What's New entry as @picnixz suggested?

Misc/NEWS.d/next/Library/2025-01-21-11-48-19.gh-issue-129027.w0vxzZ.rst

srinivasreddy · 2025-01-30T09:30:24Z

@tomasr8 Thanks 👍🏾 . Please review again?

picnixz · 2025-02-01T20:53:43Z

The What's New is still missing (it's something that you need to add in Doc/whatsnew/3.14.rst I think). The NEWS (blurb) entry is only for the full changelog, but deprecation notices are also communicated there so that they have better visibility. You can put this change in the Pending Removal section (as we are now emitting a warning)

picnixz · 2025-02-07T10:11:35Z

I'll review it in a few minutes, but I have some comments on some wording. And I think we already mentioned to avoid force pushing, so please do so in the future. Avoid rebasing to merge upstream and prefer using the update button instead. Or if it becomes too messy, just create a new branch to be sure you don't trigger unnecessary review requests

picnixz

After commenting the files, I think you can create a wrapper around _clear_type_cache that suppresses its deprecation warning use instead of suppressing the warning around the entire test. If other deprecation warnings appear we want them to be printed.

Doc/deprecations/pending-removal-in-future.rst

Doc/whatsnew/3.14.rst

Python/sysmodule.c

Misc/NEWS.d/next/Library/2025-01-21-11-48-19.gh-issue-129027.w0vxzZ.rst

Lib/test/test_type_cache.py

picnixz · 2025-02-07T10:29:25Z

Lib/test/test_type_cache.py

 type_assign_specific_version_unsafe = _testinternalcapi.type_assign_specific_version_unsafe
 type_assign_version = _testcapi.type_assign_version
 type_modified = _testcapi.type_modified
+ignore_deprecation = warnings_helper.ignore_warnings(category=DeprecationWarning)


This should be a dummy decorator if _clear_type_cache is None.

Lib/test/test_sys.py

picnixz · 2025-02-07T10:30:18Z

Lib/test/test_cmd_line.py

        self.assertEqual(rc, 0)

    @unittest.skipUnless(sysconfig.get_config_var('Py_TRACE_REFS'), "Requires --with-trace-refs build option")
+    @warnings_helper.ignore_warnings(category=DeprecationWarning)


Can we use this one only when doing assert_python_ok?

picnixz · 2025-02-07T10:30:24Z

Lib/test/test_cmd_line.py

        self.assertIn(b'True', out)

    @unittest.skipUnless(sysconfig.get_config_var('Py_TRACE_REFS'), "Requires --with-trace-refs build option")
+    @warnings_helper.ignore_warnings(category=DeprecationWarning)


picnixz · 2025-02-07T10:31:12Z

Lib/test/test_type_cache.py

        self.assertNotEqual(type_get_version(C), 0)
        self.assertNotEqual(type_get_version(C), c_ver)

+    @ignore_deprecation


Can we only protect the _clear_type_cache call instead of the entire test?

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…0vxzZ.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

srinivasreddy · 2025-02-07T12:25:12Z

@picnixz Please review again.

Lib/test/test_cmd_line.py

picnixz · 2025-02-07T12:31:16Z

Lib/test/test_type_cache.py

+            with warnings.catch_warnings():
+                warnings.simplefilter("ignore", DeprecationWarning)


Maybe you can wrap clear_type_cache with a waraning filter:

def clear_type_cache(): with warnings.catch_warnings(): ... _clear_type_cache()

srinivasreddy · 2025-02-07T13:23:49Z

@picnixz Done.

tomasr8 · 2025-02-17T11:08:14Z

@srinivasreddy There are some conflicts with main now, could you fix them please?

srinivasreddy · 2025-02-17T11:36:12Z

@tomasr8 Done.

srinivasreddy requested a review from ericsnowcurrently as a code owner January 20, 2025 06:38

bedevere-app bot mentioned this pull request Jan 20, 2025

Raise DeprecationWarning for sys._clear_type_cache #129027

Closed

bedevere-app bot added the awaiting review label Jan 20, 2025

sobolevn reviewed Jan 20, 2025

View reviewed changes

Lib/test/test_sys.py Outdated Show resolved Hide resolved

sobolevn reviewed Jan 20, 2025

View reviewed changes

Lib/test/test_sys.py Outdated Show resolved Hide resolved

tomasr8 reviewed Jan 20, 2025

View reviewed changes

Python/sysmodule.c Outdated Show resolved Hide resolved

srinivasreddy requested a review from JelleZijlstra as a code owner January 20, 2025 16:13

srinivasreddy requested review from sobolevn and tomasr8 January 21, 2025 07:43

tomasr8 reviewed Jan 21, 2025

View reviewed changes

Lib/test/test_sys.py Outdated Show resolved Hide resolved

Lib/test/test_type_cache.py Outdated Show resolved Hide resolved

Python/sysmodule.c Outdated Show resolved Hide resolved

tomasr8 reviewed Jan 21, 2025

View reviewed changes

Python/sysmodule.c Outdated Show resolved Hide resolved

picnixz reviewed Jan 23, 2025

View reviewed changes

Python/sysmodule.c Outdated Show resolved Hide resolved

picnixz reviewed Jan 23, 2025

View reviewed changes

Misc/NEWS.d/next/Library/2025-01-21-11-48-19.gh-issue-129027.w0vxzZ.rst Outdated Show resolved Hide resolved

picnixz reviewed Jan 23, 2025

View reviewed changes

Python/sysmodule.c Outdated Show resolved Hide resolved

srinivasreddy requested review from picnixz and tomasr8 January 29, 2025 16:01

tomasr8 reviewed Jan 30, 2025

View reviewed changes

Misc/NEWS.d/next/Library/2025-01-21-11-48-19.gh-issue-129027.w0vxzZ.rst Outdated Show resolved Hide resolved

srinivasreddy requested a review from tomasr8 January 30, 2025 09:30

srinivasreddy requested review from AA-Turner, FFY00, brettcannon, corona10, freakboy3742, kumaraditya303, sethmlarson and willingc as code owners February 7, 2025 07:52

tomasr8 approved these changes Feb 7, 2025

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Feb 7, 2025

picnixz reviewed Feb 7, 2025

View reviewed changes

srinivasreddy and others added 8 commits February 7, 2025 16:40

Update Doc/whatsnew/3.14.rst

3d2bca7

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Doc/deprecations/pending-removal-in-future.rst

4b45930

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Misc/NEWS.d/next/Library/2025-01-21-11-48-19.gh-issue-129027.w…

8366a2d

…0vxzZ.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Python/sysmodule.c

0310eb2

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_type_cache.py

c98e6dc

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_sys.py

da4c9c1

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Fix merge conflicts

bc1844e

Remove the introduced spaces

bb4d5e4

picnixz reviewed Feb 7, 2025

View reviewed changes

Address review comments

160f0f7

srinivasreddy added 2 commits February 17, 2025 17:01

Merge branch 'main' into pythongh-129027

aa1cc67

Update pending-removal-in-future.rst

a19ea6b

picnixz approved these changes Feb 17, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels Feb 17, 2025

naizhao mentioned this pull request Feb 23, 2025

Compilation of HACL fails under macOS Silicon for version 3.14 #130478

Closed

Merge branch 'main' into pythongh-129027

edb99cf

hugovk merged commit 8783cec into python:main Apr 25, 2025
42 checks passed

bedevere-app bot removed the awaiting merge label Apr 25, 2025

This was referenced May 18, 2025

GH-130478: Fixed HACL compilation failure on macOS Silicon #134177

Closed

gh-130478: Fixed HACL compilation failure on macOS Silicon #134188

Merged

		with warnings.catch_warnings():
		warnings.simplefilter("ignore", DeprecationWarning)

Uh oh!

gh-129027: Raise DeprecationWarning for sys._clear_type_cache #129043

gh-129027: Raise DeprecationWarning for sys._clear_type_cache #129043

Uh oh!

Conversation

srinivasreddy commented Jan 20, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomasr8 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tomasr8 commented Jan 20, 2025

Uh oh!

srinivasreddy commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomasr8 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

srinivasreddy commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

picnixz commented Feb 1, 2025

Uh oh!

picnixz commented Feb 7, 2025

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

picnixz Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

picnixz Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

picnixz Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

srinivasreddy commented Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

picnixz Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

srinivasreddy commented Feb 7, 2025

Uh oh!

tomasr8 commented Feb 17, 2025

Uh oh!

srinivasreddy commented Feb 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

srinivasreddy commented Jan 20, 2025 •

edited by bedevere-app bot

Loading

srinivasreddy commented Jan 21, 2025 •

edited

Loading

srinivasreddy commented Jan 30, 2025 •

edited

Loading