gh-128690: Use test_embed in PGO profile builds again #129377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test_embed is slow and mostly spawns sub-processes. I'm not convinced that it's an useful tests to train the PGO build. |
|
I'd prefer a more explicit announcement if |
I suggest to also remove test_embed from 3.12 and 3.13 in this case, and document the change in the Build category. |
I have opened #129660. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the temporal commit b00e125.
The issue with
test_init_pyvenv_cfgfailing is closed as resolved.cc @ned-deily
test_embed.test_init_pyvenv_cfg()fails #128690