KEMBAR78
gh-132657: Add free-threading scaling benchmark for copy.copy and copy.deepcopy by eendebakpt · Pull Request #132658 · python/cpython · GitHub
Skip to content

Conversation

@eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Apr 17, 2025

In this branch two benchmarks for the free-threading scaling are added. They are not completely microbenchmarks (they test multiple aspects of the free-threaded performance).

Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but in general my preference is to add these benchmarks when we fix the scaling issue. I think of these like regression tests, and having a mix of "passing" and "failing" cases makes it harder to notice regressions.

Co-authored-by: Sam Gross <colesbury@gmail.com>
@eendebakpt
Copy link
Contributor Author

Thanks for the feedback. I suspect we will only need one of the two benchmarks as a regression test (as the reason for not scaling seems to be the same). Once we have a better scaling, I will remove one of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants