KEMBAR78
gh-136355: Deprecate `-b` and `-bb` CLI flags in 3.15 by sobolevn · Pull Request #136363 · python/cpython · GitHub
Skip to content

gh-136355: Deprecate -b and -bb CLI flags in 3.15 #136363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 14, 2025
Merged

gh-136355: Deprecate -b and -bb CLI flags in 3.15 #136363

merged 8 commits into from
Sep 14, 2025
+34 −0

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 7, 2025 •
edited by github-actions bot
Loading

@sobolevn sobolevn requested review from hugovk, malemburg and vstinner July 7, 2025 09:33
@bedevere-app bedevere-app bot mentioned this pull request Jul 7, 2025
Closed
StanFromIreland
StanFromIreland reviewed Jul 7, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to pending-removal-in-3.17.rst?

Also, -bb is not documented and must be unliked/escaped (I don't know what to call: !) to stop errors.

vstinner
vstinner reviewed Jul 7, 2025
View reviewed changes
malemburg
malemburg requested changes Jul 7, 2025
View reviewed changes
Copy link
Member

@malemburg malemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the wording changes, this LGTM.

@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

malemburg
malemburg reviewed Jul 7, 2025
View reviewed changes
hugovk
hugovk reviewed Jul 7, 2025
View reviewed changes
vstinner
vstinner reviewed Aug 5, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR to not emit a deprecation warning and not schedule the flag removal?

Can you also deprecate PyConfig.bytes_warning member in the doc? https://docs.python.org/dev/c-api/init_config.html#c.PyConfig.bytes_warning

@sobolevn sobolevn requested a review from AA-Turner as a code owner September 10, 2025 15:50
vstinner
vstinner reviewed Sep 10, 2025
View reviewed changes
@sobolevn sobolevn requested a review from FFY00 as a code owner September 10, 2025 16:04
@sobolevn
Copy link
Member Author

sobolevn commented Sep 10, 2025 •
edited
Loading

Done! I addressed all feedback: now we no longer plan to remove -b and -bb, we will only be making them no-op. No warning is raised.

Please, take another look :)

vstinner
vstinner reviewed Sep 11, 2025
View reviewed changes
@malemburg
Copy link
Member

I don't think we should remove these options anytime soon. Why possibly break code that's using them ?

Instead, we could simply remove the documentation and make them no-ops, but still accept them on the command line.

vstinner
vstinner reviewed Sep 11, 2025
View reviewed changes
sobolevn and others added 2 commits September 14, 2025 14:44
@sobolevn @vstinner
Update Doc/c-api/init_config.rst
7a27430 
Co-authored-by: Victor Stinner <vstinner@python.org>
@sobolevn
Adress review
3eb2974
StanFromIreland
StanFromIreland reviewed Sep 14, 2025
View reviewed changes
@sobolevn @StanFromIreland
Update Doc/c-api/init_config.rst
117872f 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland
Copy link
Member

FYI bedevere is still waiting for changes: #136363 (comment)

@sobolevn
Copy link
Member Author

I have made the requested changes; please review again. To please the bot :)

@bedevere-app
Copy link

bedevere-app bot commented Sep 14, 2025

Thanks for making the requested changes!

@malemburg: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from malemburg September 14, 2025 15:07
vstinner
vstinner approved these changes Sep 14, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

malemburg
malemburg requested changes Sep 14, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Sep 14, 2025

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

malemburg
malemburg approved these changes Sep 14, 2025
View reviewed changes
Copy link
Member

@malemburg malemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see the original, just the suggestion. All good now.

StanFromIreland
StanFromIreland approved these changes Sep 14, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn sobolevn merged commit 1c984ba into python:main Sep 14, 2025
56 of 61 checks passed
@sobolevn
Copy link
Member Author

Thanks everyone! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@vstinner vstinner vstinner approved these changes

@malemburg malemburg malemburg approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @malemburg @StanFromIreland @vstinner @hugovk