KEMBAR78
[3.14] gh-138860: Lazy import rlcompleter in pdb to avoid deadlock in subprocess (GH-139185) by miss-islington · Pull Request #139280 · python/cpython · GitHub
Skip to content

[3.14] gh-138860: Lazy import rlcompleter in pdb to avoid deadlock in subprocess (GH-139185) #139280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2025
Merged

[3.14] gh-138860: Lazy import rlcompleter in pdb to avoid deadlock in subprocess (GH-139185) #139280

merged 3 commits into from
Oct 10, 2025

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 24, 2025 •
edited by bedevere-app bot
Loading

@gaogaotiantian @miss-islington
pythongh-138860: Lazy import rlcompleter in pdb to avoid deadlock in …
e03b206 
…subprocess (pythonGH-139185)

(cherry picked from commit c8624cd)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
This was referenced Sep 24, 2025
Closed
Merged
@gaogaotiantian
Copy link
Member

We need to wait for 3.14.0 for this PR because it's not critical for rc.

@encukou
Copy link
Member

encukou commented Sep 24, 2025 •
edited
Loading

The original commit to main broke refleak buildbots; do not merge this as is.

@gaogaotiantian
Copy link
Member

Just to add that even though the refleak is triggered by this PR, the changes in the PR is valid. If we fixed the issue for rlcompleter, we can probably merge this as it is. Or we could do something like #139305 to make the rlcompleter read lazy and without side effects (well it still adds an atexit callback).

@encukou
Copy link
Member

encukou commented Oct 9, 2025

Updated with a backport of the fix-up, GH-139305
(I was away when it was time to review that, sorry!)

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 10, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 6c10f12 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139280%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 10, 2025
@encukou encukou merged commit 51b1043 into python:3.14 Oct 10, 2025
109 of 115 checks passed
@encukou encukou mentioned this pull request Oct 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @gaogaotiantian @encukou @bedevere-bot