KEMBAR78
gh-138044: Fix `importlib.resources.files` deprecation docs by sobolevn · Pull Request #139632 · python/cpython · GitHub
Skip to content

gh-138044: Fix importlib.resources.files deprecation docs #139632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2025
Merged

gh-138044: Fix importlib.resources.files deprecation docs #139632

merged 1 commit into from
Oct 11, 2025

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 5, 2025 •
edited by github-actions bot
Loading

.. deprecated-removed:: can't be left in the docs if the right version is the current one.
Docs build will start to fail when .. deprecated-removed:: ... 3.15 is left.

Also, whatsnew is updated, we need to add all removals there.

CC @donBarbos

📚 Documentation preview 📚: https://cpython-previews--139632.org.readthedocs.build/

@sobolevn sobolevn requested a review from FFY00 October 5, 2025 21:33
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Oct 5, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Oct 5, 2025
@bedevere-app bedevere-app bot mentioned this pull request Oct 5, 2025
Closed
donBarbos
donBarbos approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@donBarbos donBarbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn sobolevn merged commit d6dd64a into python:main Oct 11, 2025
38 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Oct 11, 2025
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL Refleaks 3.x (tier-1) has failed when building commit d6dd64a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1610/builds/2220) and take a look at the build logs.
  4. Check if the failure is related to this commit (d6dd64a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1610/builds/2220

Failed tests:

  • test_free_threading

Test leaking resources:

  • test_free_threading: file descriptors

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 7, done.        
remote: Counting objects:  14% (1/7)        
remote: Counting objects:  28% (2/7)        
remote: Counting objects:  42% (3/7)        
remote: Counting objects:  57% (4/7)        
remote: Counting objects:  71% (5/7)        
remote: Counting objects:  85% (6/7)        
remote: Counting objects: 100% (7/7)        
remote: Counting objects: 100% (7/7), done.        
remote: Compressing objects:  25% (1/4)        
remote: Compressing objects:  50% (2/4)        
remote: Compressing objects:  75% (3/4)        
remote: Compressing objects: 100% (4/4)        
remote: Compressing objects: 100% (4/4), done.        
remote: Total 7 (delta 3), reused 3 (delta 3), pack-reused 0 (from 0)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to 'd6dd64ac654898b4ce713c16c49eadb0c6e9d7dc'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at d6dd64ac654 gh-138044: Fix `importlib.resources.files` deprecation docs (#139632)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdec found; falling back to pure-Python version for the decimal module

make: *** [Makefile:2489: buildbottest] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

+1 more reviewer

@donBarbos donBarbos donBarbos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @bedevere-bot @emmatyping @donBarbos