gh-133171: Make the executor_list thread-safe #140038
Conversation
aisk
requested review from
ZeroIntensity,
ericsnowcurrently and
markshannon
as code owners
aisk
changed the title
There was a problem hiding this comment.
I'm not entirely sure that a mutex is safe here, because we're locking code paths that call Py_DECREF. @Fidget-Spinner, can these paths escape?
| #endif | ||
|
|
||
| // Executor list lock macros for thread-safe access to executor linked lists | ||
| #define EXECUTOR_LIST_LOCK(interp) \ |
There was a problem hiding this comment.
The point of FT_MUTEX_LOCK is to prevent macros like this. If you're really against repeating interp->executor_list_lock several times, you can define a macro for that instead.
|
In theory, |
|
I am not sure if making executor_list operations thread-safe at this point is good idea. |
4 participants
The idea is simple and naive: just add a
PyMutexto thePyInterpreterStatefor theexecutor_listunder thenogilbuild, and lock or unlock the mutex in all functions that operate on theexecutor_list.Since I'm not very familiar with the related code, there might be a better way to do this, so any feedback would be appreciated!