[3.9] bpo-39481: Fix duplicate SimpleQueue type in test_genericalias.py (GH-22619) #22624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py (pythonGH-22619) There are two different `SimpleQueue` types imported (from `multiprocessing.queues` and `queue`) in `Lib/test/test_genericalias.py`, the second one shadowing the first one, making the first one not actually tested. Fix by using different names. Automerge-Triggered-By: @gvanrossum. (cherry picked from commit b2c0a43) Co-authored-by: Saiyang Gou <gousaiyang@163.com>
gvanrossum
approved these changes
Oct 9, 2020
|
Looks like there is a glitch with GitHub Actions causing the Ubuntu build to fail. Can we somehow rerun the build? |
|
Close and reopen to trigger tests. |
|
This works now. Can we merge it? |
|
@gvanrossum: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two different
SimpleQueuetypes imported (frommultiprocessing.queuesandqueue) inLib/test/test_genericalias.py, the second one shadowing the first one, making the first one not actually tested. Fix by using different names.Automerge-Triggered-By: @gvanrossum.
(cherry picked from commit b2c0a43)
Co-authored-by: Saiyang Gou gousaiyang@163.com
https://bugs.python.org/issue39481