bpo-44002: Switch to lru_cache in urllib.parse. #25798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urllib.parse now uses functool.lru_cache for its internal URL splitting and quoting caches instead of rolling its own like its the 90s. The undocumented internal Quoted class and clear_cache() APIs are now deprecated, for removal in 3.14.
|
I won't merge this until after the 3.10 branch is cut and all of the https://bugs.python.org/issue43882 fixes are in. |
rhettinger
reviewed
May 1, 2021
rhettinger
reviewed
May 1, 2021
rhettinger
reviewed
May 1, 2021
gpshead
commented
May 2, 2021
|
It looks like the Travis CI failed only because of excess whitespace. Running 'make patchcheck' would likely clear it. |
|
This final change, which addressed the review comments from the reviewers looks good to me. |
twisted, gevent, and our own libregrtest use it in test suites. We'll keep it for them. ... and skip Pending on Quoter's DeprecationWarning. No uses of that have been found externally. Also reoragnizes the unittest a bit to be cleaner and fixes a whitespace problem.
|
Status: awaiting a copy of #25853 to be merged into |
akulakov
reviewed
May 11, 2021
serhiy-storchaka
approved these changes
May 11, 2021
|
@gpshead: Status check is done, and it's a failure ❌ . |
|
@gpshead: Status check is done, and it's a success ❌ . |
|
Excellent change. @gpshead :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urllib.parse now uses functool.lru_cache for its internal URL splitting and
quoting caches instead of rolling its own like its the 90s.
The undocumented internal Quoted class is now deprecated, for removal in 3.14.
No existing users were found.
clear_cache() is kept as twisted, gevent, and our own regression test runner were
found to be using it in their test suites.
https://bugs.python.org/issue44002
Automerge-Triggered-By: GH:gpshead