KEMBAR78
bpo-46072: Improve LOAD_METHOD stats by markshannon · Pull Request #31104 · python/cpython · GitHub
Skip to content

bpo-46072: Improve LOAD_METHOD stats #31104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2022
Merged

bpo-46072: Improve LOAD_METHOD stats #31104

merged 2 commits into from
Feb 7, 2022

Conversation

@markshannon
Copy link
Member

@markshannon markshannon commented Feb 3, 2022 •
edited by bedevere-bot
Loading

We were falsely attributing a lot of specialization failure to SPEC_FAIL_EXPECTED_ERROR.

With this PR that number drops to 0.

Stats from the standard benchmark suite:

LOAD_METHOD:
 unquickened:    35297570 1.8%
    deferred:   309896720 15.7%
       deopt:      613976 0.0%
         hit:  1600750204 80.9%
        miss:    32841119 1.7%
  success:     1499820
  failure:     4371143
    kind  0:     8556 0.2%
    kind  2:   311220 7.1%
    kind  7:      420 0.0%
    kind  8:     1635 0.0%
    kind  9:    51709 1.2%
    kind 10:    13908 0.3%
    kind 12:    14375 0.3%
    kind 13:     7182 0.2%
    kind 14:       63 0.0%
    kind 15:     4529 0.1%
    kind 17:    24864 0.6%
    kind 18:   329370 7.5%
    kind 19:      147 0.0%
    kind 20:  1125766 25.8%
    kind 21:  1507036 34.5%
    kind 22:   760037 17.4%
    kind 23:   210326 4.8%

Collectively kinds 20-23 represent 82% of failures, which provides us a much better insight into how to specialize LOAD_METHOD.

https://bugs.python.org/issue46072

@markshannon markshannon force-pushed the fix-load-method-stats branch from 87541dd to 7d601e9 Compare February 3, 2022 17:08
@markshannon markshannon changed the title bpo-46072: Improve load method stats bpo-46072: Improve LOAD_METHOD stats Feb 3, 2022
@markshannon markshannon merged commit 062460e into python:main Feb 7, 2022
@markshannon markshannon mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon @the-knights-who-say-ni @bedevere-bot