KEMBAR78
bpo-46072: Add per-instruction miss stats. by markshannon · Pull Request #31108 · python/cpython · GitHub
Skip to content

bpo-46072: Add per-instruction miss stats. #31108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

bpo-46072: Add per-instruction miss stats. #31108

merged 1 commit into from
Feb 4, 2022

Conversation

@markshannon
Copy link
Member

@markshannon markshannon commented Feb 3, 2022 •
edited by bedevere-bot
Loading

Also explictly mark which instructions are specializable in stats. It is not the job of the summary script to guess which instructions are specializable.

Per instruction stats now look like:

LOAD_METHOD_NO_DICT: 488505073 0.7% 84.8%
    Misses: 5702208 1.2%
STORE_ATTR_INSTANCE_VALUE: 485786899 0.7% 85.5%
    Misses: 6904720 1.4%
BINARY_OP_SUBTRACT_INT: 460413189 0.7% 86.2%
    Misses: 2710155 0.6%
...

https://bugs.python.org/issue46072

@markshannon markshannon requested a review from sweeneyde February 3, 2022 19:09
sweeneyde
sweeneyde approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@sweeneyde sweeneyde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM! I tested this out and the results look reasonable.

@markshannon markshannon merged commit 832876b into python:main Feb 4, 2022
@markshannon markshannon deleted the deopt-stats-per-instruction branch February 4, 2022 09:56
@markshannon markshannon mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sweeneyde sweeneyde sweeneyde approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon @sweeneyde @the-knights-who-say-ni @bedevere-bot