-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-99948: Add emscripten platform support to ctypes.util.find_library #99950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to write a test for this? (I don't actually know if we have other emscripten platform tests, but if we do it would certainly be good to assert that we can load and make calls to a wasm binary here.)
|
I added a test. Is there a way I can run Emscripten platform tests locally or via CI? @brettcannon |
|
🤖 New build scheduled with the buildbot fleet by @brettcannon for commit 07818b6 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
@ryanking13 we can run PRs against the whole buildbot fleet (which I have now triggered). |
|
Thanks, @brettcannon. Though I think the |
|
You can run them locally via https://github.com/python/cpython/tree/main/Tools/wasm , but if the ctypes tests are turned off then I'm not comfortable accepting this PR until they are turned on and passing. |
Yes, that makes sense. I guess we (Pyodide) should just add a patch for this until CPython includes more external libraries to WASM build. |
I'm going to close this then as I don't know if/when that would happen. |
This adds
ctypes.util.find_libraryfunction for emscripten platform.Emscripten internally uses
LD_LIBRARY_PATHenv variable to search libraries.