Fix overload issue

Ivan Levkivskyi · Ivan Levkivskyi · commit 59963c4ce1ca · 2023-08-10T18:26:36.000+01:00
diff --git a/mypy/constraints.py b/mypy/constraints.py
@@ -963,8 +963,8 @@ def visit_callable_type(self, template: CallableType) -> list[Constraint]:
                         if (tk == ARG_STAR and ak != ARG_STAR) or (
                             tk == ARG_STAR2 and ak != ARG_STAR2
                         ):
-                            # Unpack may have shifted indices.
-                            if not unpack_present:
+                            if cactual.param_spec():
+                                # TODO: we should be more careful also for non-ParamSpec functions
                                 continue
                         if isinstance(a, ParamSpecType):
                             # TODO: can we infer something useful for *T vs P?
diff --git a/test-data/unit/check-overloading.test b/test-data/unit/check-overloading.test
@@ -6569,3 +6569,20 @@ S = TypeVar("S", bound=str)
 def foo(x: int = ...) -> Callable[[T], T]: ...
 @overload
 def foo(x: S = ...) -> Callable[[T], T]: ...
+
+[case testOverloadGenericStarArgOverlap]
+from typing import Any, Callable, TypeVar, overload, Union, Tuple, List
+
+F = TypeVar("F", bound=Callable[..., Any])
+S = TypeVar("S", bound=int)
+
+def id(f: F) -> F: ...
+
+@overload
+def struct(*cols: S) -> int: ...
+@overload
+def struct(__cols: Union[List[S], Tuple[S, ...]]) -> int: ...
+@id
+def struct(*cols: Union[S, Union[List[S], Tuple[S, ...]]]) -> int:
+    pass
+[builtins fixtures/tuple.pyi]
