execute check_deprecated before warn_deprecated_overload_item when analysing "normal" methods (like we do when in other cases).

tyralla · tyralla · commit c95f93678317 · 2025-01-19T22:29:05.000+01:00
diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
@@ -1491,6 +1491,7 @@ def check_call_expr_with_callee_type(
                     if (symbol := base.names.get(member)) is not None:
                         node = symbol.node
                         break
+            self.chk.check_deprecated(node, e)
             self.chk.warn_deprecated_overload_item(
                 node, e, target=callee_type, selftype=object_type
             )
diff --git a/test-data/unit/check-deprecated.test b/test-data/unit/check-deprecated.test
@@ -402,29 +402,34 @@ class A:
     def h(self, v: int) -> A: ...
     @overload
     def h(self, v: str) -> A: ...
-    @deprecated("use `h2`  instead")
+    @deprecated("use `h2` instead")
     def h(self, v: Union[int, str]) -> A: ...
 
 class B(A): ...
 
+int_or_str: Union[int, str]
+
 a = A()
 a.f(1)  # E: overload def (self: __main__.A, v: builtins.int) of function __main__.A.f is deprecated: pass `str` instead
 a.f("x")
-
-int_or_str: Union[int, str]
-a.f(int_or_str)
+a.f(int_or_str)  # E: overload def (self: __main__.A, v: builtins.int) of function __main__.A.f is deprecated: pass `str` instead
 a.g(1)
 a.g("x")  # E: overload def (self: __main__.A, v: builtins.str) of function __main__.A.g is deprecated: pass `int` instead
-a.h(1)  # E: function __main__.A.h is deprecated: use `h2`  instead
-a.h("x")  # E: function __main__.A.h is deprecated: use `h2`  instead
+a.g(int_or_str)  # E: overload def (self: __main__.A, v: builtins.str) of function __main__.A.g is deprecated: pass `int` instead
+a.h(1)  # E: function __main__.A.h is deprecated: use `h2` instead
+a.h("x")  # E: function __main__.A.h is deprecated: use `h2` instead
+a.h(int_or_str)  # E: function __main__.A.h is deprecated: use `h2` instead
 
 b = B()
 b.f(1)  # E: overload def (self: __main__.A, v: builtins.int) of function __main__.A.f is deprecated: pass `str` instead
 b.f("x")
+b.f(int_or_str)  # E: overload def (self: __main__.A, v: builtins.int) of function __main__.A.f is deprecated: pass `str` instead
 b.g(1)
 b.g("x")  # E: overload def (self: __main__.A, v: builtins.str) of function __main__.A.g is deprecated: pass `int` instead
-b.h(1)  # E: function __main__.A.h is deprecated: use `h2`  instead
-b.h("x")  # E: function __main__.A.h is deprecated: use `h2`  instead
+b.g(int_or_str)  # E: overload def (self: __main__.A, v: builtins.str) of function __main__.A.g is deprecated: pass `int` instead
+b.h(1)  # E: function __main__.A.h is deprecated: use `h2` instead
+b.h("x")  # E: function __main__.A.h is deprecated: use `h2` instead
+b.h(int_or_str)  # E: function __main__.A.h is deprecated: use `h2` instead
 
 [builtins fixtures/tuple.pyi]
 
