Keep track of fine-grained deps for modules in typeshed #10034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if we assume that typeshed stubs don't change, we need the deps when bringing in new stubs when following imports during a fine-grained increment. This fixes false positives when following imports to `six` and `requests`. Some modules are always part of the initial build, and we can still skip generating deps for them, as an optimization. I only tested this manually, since I couldn't figure out an easy way to reproduce the issue in our tests. Fixes #10033.
ilevkivskyi
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if we assume that typeshed stubs don't change, we need the deps
when bringing in new stubs when following imports during a fine-grained
increment.
This fixes false positives when following imports to
sixandrequests.Some modules are always part of the initial build, and we can still
skip generating deps for them, as an optimization.
I only tested this manually, since I couldn't figure out an easy way to
reproduce the issue in our tests.
Fixes #10033.