KEMBAR78
Fix following stub imports in daemon when using --follow-imports=skip by JukkaL · Pull Request #10092 · python/mypy · GitHub
Skip to content

Conversation

@JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Feb 15, 2021

Find added stubs in daemon when using --follow-imports=skip. Previously
it was often necessary to restart the daemon to find new stubs. This was
inconsistent, as the initial build did follow imports to stubs but incremental
runs didn't (at least reliably).

Add an optimization that avoids checking modules within top-level packages
that clearly don't exist.

This still can regress performance in large codebases somewhat significantly.
I'll create follow-up PRs that make the regression less bad.

Also mark follow_imports_for_stubs as unsupported in the daemon. I don't
think that it worked reliably before, and now it works even less well.

@JukkaL JukkaL merged commit 07edb84 into master Feb 15, 2021
@JukkaL JukkaL deleted the daemon-follow-site-pkgs branch February 15, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants