KEMBAR78
docs: add using typing.no_type_check decorator to silence mypy by chrisbeardy · Pull Request #10098 · python/mypy · GitHub
Skip to content

Conversation

@chrisbeardy
Copy link

@chrisbeardy chrisbeardy commented Feb 17, 2021

No description provided.

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experience no_type_check is used quite rarely, so mentioning it under "common issues" is probably not the best location. However, we could discuss it under "Silencing type errors" in type_inference_and_annotations.rst. Would you like to move the new section there?

@chrisbeardy
Copy link
Author

I added it to the common issues section as that section already shows two ways to silence type errors and the no_type_check is just a third. It makes sense to keep the ways to silence errors together. I'm not sure it makes sense as a standalone section in type_interence_and_notations.rst. I could create a new section altogether with all the different ways to silence the type errors?

@hauntsaninja
Copy link
Collaborator

Thanks for you contribution! I agree with Jukka that this shouldn't be in common_issues, I opened #12713 to move this to type_interence_and_notations.rst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants