Only import distutils if it is needed #10203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils is deprecated in python 3.10, so we only import it if it is needed, which should only be python < 3.2
|
Mypy doesn't support Python < 3.2, so maybe this branch can just be removed? |
|
Never mind, this file has to work in Python 2 because it's used for finding site-packages in Python 2. |
21 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
distutils is deprecated in python 3.10, so we only import it if it is
needed, which should only be python < 3.2
Test Plan
All tests still pass. This is a trivial change and shouldn't cause any problems.