KEMBAR78
[mypyc] Add incref in CPyDict_SetDefault by 97littleleaf11 · Pull Request #10334 · python/mypy · GitHub
Skip to content

[mypyc] Add incref in CPyDict_SetDefault #10334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2021
Merged

[mypyc] Add incref in CPyDict_SetDefault #10334

merged 2 commits into from
Apr 19, 2021

Conversation

97littleleaf11
Copy link
Collaborator

Description

Closes mypyc/mypyc#831

Test Plan

JelleZijlstra
JelleZijlstra reviewed Apr 16, 2021
View reviewed changes
JukkaL
JukkaL approved these changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@JukkaL JukkaL merged commit b367f26 into python:master Apr 19, 2021
@97littleleaf11 97littleleaf11 deleted the fix-dict-setdefault branch April 23, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Segmentation fault using setdefault

3 participants

@97littleleaf11 @JelleZijlstra @JukkaL