Fix inference of IntEnum value attribute type (Python 2) #10417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enum stubs for Python 2 are slightly different from Python 3. The fix in #10412 didn't quite work in Python 2 mode, since `IntEnum` doesn't define `__new__`, and the `__new__` from `builtins.int` is found instead. Work around this by skipping any `__new__` methods found in built-in types. I gave up trying to write a test case for this. It's tricky because `enum` is in Python 3 stdlib but not in Python 2 stdlib.
ilevkivskyi
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enum stubs for Python 2 are slightly different from Python 3.
The fix in #10412 didn't quite work in Python 2 mode, since
IntEnumdoesn't define
__new__, and the__new__frombuiltins.intisfound instead. Work around this by skipping any
__new__methodsfound in built-in types.
I gave up trying to write a test case for this. It's tricky because
enumis in Python 3 stdlib but not in Python 2 stdlib.