[mypyc] Support __setitem__, __delitem__, __len__ and __contains__ #10451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TH3CHARLie
approved these changes
May 14, 2021
| generated = {} # type: Dict[str, str] | ||
| # Sort for determinism on Python 3.5 | ||
| for name, (slot, generator) in sorted(table.items()): | ||
| for name, (slot, generator) in sorted(table.items(), reverse=True): |
There was a problem hiding this comment.
This because the implementation depends on processing __setitem__ before __delitem__. This kind of hacky -- I'll add a comment in a follow-up PR, or see if this could be refactored.
|
Related issue: mypyc/mypyc#839 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these couldn't be used in compiled classes.
__setitem__and__delitem__are implemented by a single wrapper function. If the value isNULL, it should act as
__delitem__. This makes the implementation non-trivial. First, weneed to support both a single variant and two variants being defined in a class. Second, when
overriding, we need to use
super(), if we only override one of them.The other dunders are straightforward.
The implementation is pretty verbose. I'll look at refactoring it in a separate PR.
This has some overlap with the previous PR #10211 by @sohailsomani.