KEMBAR78
stubgenc: type check for getattr changes by hauntsaninja · Pull Request #10523 · python/mypy · GitHub
Skip to content

stubgenc: type check for getattr changes #10523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2021
Merged

stubgenc: type check for getattr changes #10523

merged 2 commits into from
May 21, 2021

Conversation

@hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented May 21, 2021 •
edited
Loading

python/typeshed#5516 makes changes to getattr
that would introduce type errors here.

infer_sig_from_docstring will return False if docstr is None, so the code itself is fine.

hauntsaninja added 2 commits May 21, 2021 15:24
stubgenc: type check for getattr changes
21b499d 
python/typeshed#5516 makes changes to getattr
that would introduce type errors here
undo else
f7eb623
@hauntsaninja hauntsaninja merged commit 015543a into python:master May 21, 2021
@hauntsaninja hauntsaninja deleted the typecheck branch May 21, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hauntsaninja @JelleZijlstra