[mypyc] Add bytes index primitive #10950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Aug 9, 2021
|
mistakely deleted an irbuilding test |
JukkaL
reviewed
Aug 9, 2021
JukkaL
reviewed
Aug 10, 2021
| b[4] | ||
| with assertRaises(IndexError, "index out of range"): | ||
| b[-5] | ||
| b2 = bytearray([175, 255, 128, 22]) |
There was a problem hiding this comment.
Use b2: bytes here as well.
There was a problem hiding this comment.
This still needs to be updated.
|
Also the Windows 32-bit build is failing. |
97littleleaf11
changed the title
JukkaL
reviewed
Aug 11, 2021
| b[4] | ||
| with assertRaises(IndexError, "index out of range"): | ||
| b[-5] | ||
| b2 = bytearray([175, 255, 128, 22]) |
There was a problem hiding this comment.
This still needs to be updated.
|
This test case is for |
|
Ah, fair enough. This is ready to merge then. |
JukkaL
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements part of mypyc/mypyc#880.
__getitem__ops for bytes(intandshort_intas index parameter)Test Plan
Add several run tests and an irbuild test.