KEMBAR78
[mypyc] Add primitives for str.encode() by 97littleleaf11 · Pull Request #10974 · python/mypy · GitHub
Skip to content

[mypyc] Add primitives for str.encode() #10974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

[mypyc] Add primitives for str.encode() #10974

merged 1 commit into from
Aug 12, 2021

Conversation

97littleleaf11
Copy link
Collaborator

Description

Add primitives for str.encode(...)

JukkaL
JukkaL approved these changes Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now the encode_decode benchmark is about 2x faster compared to before the dedicated primitives for encode and decode were added.

@JukkaL JukkaL merged commit 3970cc3 into python:master Aug 12, 2021
@97littleleaf11 97littleleaf11 deleted the encode branch February 22, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@97littleleaf11 @JukkaL