KEMBAR78
`None.__bool__` returns `Literal[False]` by sobolevn · Pull Request #11290 · python/mypy · GitHub
Skip to content

None.__bool__ returns Literal[False] #11290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2021
Merged

None.__bool__ returns Literal[False] #11290

merged 2 commits into from
Oct 11, 2021

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 7, 2021 •
edited
Loading

Closes #11287

@sobolevn sobolevn changed the title WIP: None.__bool_ returns Literal[None], refs #11287 WIP: None.__bool_ returns Literal[None] Oct 7, 2021
@sobolevn sobolevn changed the title WIP: None.__bool_ returns Literal[None] WIP: None.__bool_ returns Literal[False] Oct 7, 2021
@sobolevn sobolevn changed the title WIP: None.__bool_ returns Literal[False] WIP: None.__bool__ returns Literal[False] Oct 7, 2021
@sobolevn sobolevn changed the title WIP: None.__bool__ returns Literal[False] None.__bool__ returns Literal[False] Oct 7, 2021
JelleZijlstra
JelleZijlstra reviewed Oct 7, 2021
View reviewed changes
@sobolevn
Copy link
Member Author

sobolevn commented Oct 7, 2021

@JelleZijlstra thanks! Now it should be fixed! 👍

hauntsaninja
hauntsaninja approved these changes Oct 10, 2021
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm! (I don't really understand the desired behaviour when show_none_errors is True)

@JelleZijlstra JelleZijlstra merged commit 8e01ad9 into python:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use _typeshed.NoneType for the type of None

3 participants

@sobolevn @JelleZijlstra @hauntsaninja