[mypyc] Implement close method for generators #12042
Conversation
|
Thanks for you PR! Could you please add a IRbuild test? You could just create a new |
There was a problem hiding this comment.
I think it might be a nicer approach to implement a close function in C in exc_ops.c, and then the generated close will just call that. We could probably call the close function out of the vtable, since we can make sure it's always at the same index. That should reduce code size and would make it easier to test the exception using PyErr_ExceptionMatches instead of copying it into sys.exc_info() first, like we do in most generated code.
That said, there's no reason not to merge this as is, because it's definitely an improvement over the status quo.
@97littleleaf11 do you have something particular you're looking for in an IR test? I think the behavioral tests cover this pretty well so I'm happy to not add more IR tests.
No. I just didn't found IR test case for generators and thought maybe we should have one. It might be useful if we are going to replace part of IR with C helper functions. |
|
@msullivan Shall we merge this PR first and then open a new issue for your suggestion about the C helper function? |
|
@97littleleaf11 my understanding is that the IR tests are designed to ensure that the python code generates correct IR. To me, IR tests seem less useful in this case, where we basically handcraft the IR. Please correct me if I'm wrong though. I'm also not sure if there's an easy way to create an IR test just for the |
Yeah, you're right and for current situation it's unnecessary. The IR test is just a double check and someone may optimize it in the future.
Yeah, this is my original idea. I didn't find one for it, or I just miss it? |
There isn't one, as far as I know |
4 participants
Description
Closes mypyc/mypyc#790
This PR implements a close method for mypyc generators according to https://www.python.org/dev/peps/pep-0342/#new-generator-method-close
Test Plan
Added tests for the following cases:
GeneratorExitGeneratorExitand raisesStopIterationGeneratorExitGeneratorExitbut raisesRuntimeError