KEMBAR78
Remove orjson stubs from default list by hauntsaninja · Pull Request #12264 · python/mypy · GitHub
Skip to content

Conversation

@hauntsaninja
Copy link
Collaborator

@srittau
Copy link
Contributor

srittau commented Mar 1, 2022

Would it make sense to remove all packages (except cryptography) that already have a scheduled release date? Upstream packages already have types, agree all.

@hauntsaninja
Copy link
Collaborator Author

I think it makes sense to remove all packages that have a py.typed release — but I took a gander and I think you've already removed all of them :-)

@srittau
Copy link
Contributor

srittau commented Mar 1, 2022

Upstream packages already have types, agree all.

This happens when you type on your phone. And I don't remember what I wanted to say instead of "agree all".

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit 187f394 into python:master Mar 1, 2022
@hauntsaninja hauntsaninja deleted the orj branch March 1, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants