Recognise both attrs and attr package names in the plugin
#12469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jhance
reviewed
Mar 27, 2022
| [builtins fixtures/attr.pyi] | ||
|
|
||
| [case testAttrsOptionalConverterNewPackage] | ||
| # flags: --strict-optional |
There was a problem hiding this comment.
Is it not on by default for tests? I tried to check but either nobody else is using this or github search is broken.
There was a problem hiding this comment.
Not sure, I just copied it from the test above.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of version 21.3.0, the attrs project provides its API under both the old
attrand newattrspackage names. This PR adds the new names to the various constants so their special behaviour is properly recognised.Test Plan
I added additional tests to check for the special behaviour of each new function. Since they have identical behaviour, I don't think duplicating all the tests for the packages is necessary. The stubs are duplicated though to ensure the plugin detects both names and doesn't just rely on object identity via
import. Currently the implementation defines inattrand imports inattrs, but this future-proofs in case that changes.