Fix union simplification performance regression #12519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
jhance
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11962 can generate large unions with many
Instancetypes withlast_known_valueset. This caused our union simplification algorithmto be extremely slow, as it hit an O(n**2) code path.
We already had a fast code path for unions of regular literal types. This
generalizes it for unions containing
Instancetypes with last knownvalues (which behave similarly to literals in a literal type context).
Also fix a union simplification bug that I encountered while writing tests
for this change.
Work on #12408.