checkexpr: speedup argument count check #12703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace List with Dict to avoid O(n**2) behavior in `check_for_extra_actual_arguments`
This manifests for instance when initializing a set with `set([...])` instead of a set
literal `{...}`. For large sets of literals (~80k entries) this change bring the
typechecking of a single set initializer from over 1 min down to under 1s.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
windows test failure looks like a flake. Is there any way to re-run the tests without pushing a new commit? |
Closing and reopening the PR should trigger a new CI run |
hauntsaninja
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace List with Dict to avoid O(n**2) behavior in
check_for_extra_actual_argumentsThis manifests for instance when initializing a set with
set([...])instead of a setliteral
{...}. For large sets of literals (~80k entries) this change bring thetypechecking of a single set initializer from over 1 min down to under 1s.