[mypyc] Replace integer floor division by a power of two with a shift #12870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
May 26, 2022
mypyc/irbuild/expression.py
Outdated
| if not isinstance(expr.right, IntExpr): | ||
| return expr | ||
| divisor = expr.right.value | ||
| n = 2 |
There was a problem hiding this comment.
This isn't super important, but I think it would be cleaner (and faster, though that doesn't really matter) to directly compute the shift instead of testing for it? I think you can do shift = divisor.bit_length() - 1 and then check that the shift is correct
There was a problem hiding this comment.
Done. We don't have a primitive for bit_length() so it may actually be slower, but I think that the code looks cleaner if we use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a microbenchmark right shift was a bit faster.