Union types: Support narrowing to Ellipsis (...) cases of Unions
#13157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
After this change, narrowing to `Ellipsis` works similarly with regards to narrowing as `None` in `Optional`s It would be a good followup refactor to delegate some of the logic from `is_singleton_type` to the actual mypy types so they could decide for themselves if they are representing singleton objects Fixes: python#13117 Co-authored-by: Zsolt Cserna <cserna.zsolt@gmail.com>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, narrowing to
Ellipsisworks similarly withregards to narrowing as
NoneinOptionalsIt would be a good followup refactor to delegate some of the logic
from
is_singleton_typeto the actual mypy types so they could decidefor themselves if they are representing singleton objects
Fixes: #13117
Co-authored-by: Zsolt Cserna cserna.zsolt@gmail.com