stubtest: Fallback to getattr_static
if an attribute can't be found on a class at runtime
#13285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stubtest currently emits false-positive errors on most of the stdlib enums in typeshed, due to this behaviour:
The
value
property exists onenum
classes, but stubtest can't see it due to some magic theenum
module does to makevalue
raise anAttributeError
if you try to access it on the class itself, rather than on an enum member. We can avoid these false-positive errors by falling back togetattr_static
if the attribute can't be found usinggetattr
.Output from running typeshed's
stubtest_stdlib.py
, with this patch checked out, relative to running the same test with mypymaster
checked out:Test Plan
I added a test.