[mypyc] Implement async for as a statement and in comprehensions
#13444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
force-pushed
the
async-for
branch
3 times, most recently
from
76edd2e to
269f634
Compare
ilevkivskyi
approved these changes
Aug 18, 2022
| ) | ||
|
|
||
| # this would be anext(obj) if it existed | ||
| anext_op = custom_op( |
There was a problem hiding this comment.
Since you are adding primitives, maybe also add few IR tests?
There was a problem hiding this comment.
I'm not sure if it would add much value here?
There was a problem hiding this comment.
(I went and merged but will add IR tests if you think it's important)
There was a problem hiding this comment.
They are much faster than run tests, and also I remember similar tests for non-async for were helpful when I implemented some special-casing a while ago (but maybe I care too much about generated code looking good, not just being correct).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on mypyc/mypyc#868.