Make join of recursive types more robust #13808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
reviewed
Oct 4, 2022
| items: list[Type] = [] | ||
| for i in range(t.length()): | ||
| items.append(self.join(t.items[i], self.s.items[i])) | ||
| items.append(join_types(t.items[i], self.s.items[i])) |
There was a problem hiding this comment.
should this be forwarding self.instance_joiner?
There was a problem hiding this comment.
FWIW it didn't, so it should be a matter of a separate PR.
There was a problem hiding this comment.
Also I am not sure it actually should.
hauntsaninja
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13795
Calculating tuple fallbacks on the fly creates a cycle between joins and subtyping. Although IMO this is conceptually not a right thing, it is hard to get rid of (unless we want to use unions in the fallbacks, cc @JukkaL). So instead I re-worked how
join_types()works w.r.t.get_proper_type(), essentially it now follows the golden rule "Always pass on the original type if possible".