KEMBAR78
Fix narrow for walrus expressions used in match statements by hauntsaninja · Pull Request #14844 · python/mypy · GitHub
Skip to content

Fix narrow for walrus expressions used in match statements #14844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

Fix narrow for walrus expressions used in match statements #14844

merged 1 commit into from
Mar 6, 2023
+23 −0

Conversation

@hauntsaninja
Copy link
Collaborator

Fixes #14843

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood added topic-pep-572 PEP 572 (walrus operator) topic-match-statement Python 3.10's match statement labels Mar 6, 2023
JukkaL
JukkaL approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JukkaL JukkaL merged commit 31f70d7 into python:master Mar 6, 2023
@hauntsaninja hauntsaninja deleted the match-walrus branch March 6, 2023 19:20
@AlexWaygood AlexWaygood mentioned this pull request Mar 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

topic-match-statement Python 3.10's match statement topic-pep-572 PEP 572 (walrus operator)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Walrus in match expression leads to type not correctly inferred in case expression

3 participants

@hauntsaninja @JukkaL @AlexWaygood