KEMBAR78

Fix `ast` warnings for Python3.12 by sobolevn · Pull Request #15558 · python/mypy · GitHub

Fix `ast` warnings for Python3.12 #15558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sobolevn merged 9 commits into master from issue-15330

Jul 3, 2023

Member

sobolevn commented Jun 30, 2023

Warnings before: #15330 (comment)
Warnings after:

(.venv312) ~/Desktop/mypy  master ✗                                                       
» python -m mypy ex.py
Success: no issues found in 1 source file

Zero :)

sobolevn added 2 commits

June 30, 2023 21:14


          Fix ast warnings for Python3.12

329a310


          Fix CI

5a70bde

JelleZijlstra approved these changes

View reviewed changes

This comment has been minimized.

Sign in to view

Member

JelleZijlstra commented Jun 30, 2023

Seems like there's more to be done. We're getting a None here:

  File "/home/runner/work/mypy/mypy/mypy/fastparse.py", line 1960, in _extract_argument_name
    return n.s.strip()

The mypy-primer hit also likely indicates a bug. It's something with type comments.

sobolevn added 2 commits

June 30, 2023 22:07


          Fix CI


          Fix CI

0bb6e99

This comment has been minimized.

Sign in to view


          Fix CI

fc11b96

This comment has been minimized.

Sign in to view


          Fix CI

73c729a

This comment has been minimized.

Sign in to view


          Fix CI

85e6b61

This comment has been minimized.

Sign in to view

sobolevn requested a review from JelleZijlstra

July 1, 2023 06:18

Member

JelleZijlstra commented Jul 3, 2023

We dropped support for 3.7 by now, so this can probably be simplified; at least there's a big merge conflict now.

sobolevn and others added 2 commits

July 3, 2023 19:07


          Merge

5c39f2d


          [pre-commit.ci] auto fixes from pre-commit.com hooks

1e50969

for more information, see https://pre-commit.ci

JelleZijlstra approved these changes

View reviewed changes

Contributor

github-actions bot commented Jul 3, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

sobolevn merged commit a759c49 into master

sobolevn deleted the issue-15330 branch

July 3, 2023 17:05

JukkaL mentioned this pull request

Fix some deprecation warnings on Python 3.12 #15576

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet