KEMBAR78
[mypyc] Don't crash on non-inlinable final local reads by ichard26 · Pull Request #15719 · python/mypy · GitHub
Skip to content

[mypyc] Don't crash on non-inlinable final local reads #15719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

[mypyc] Don't crash on non-inlinable final local reads #15719

merged 1 commit into from
Feb 28, 2024

Conversation

ichard26
Copy link
Collaborator

@ichard26 ichard26 commented Jul 19, 2023 •
edited
Loading

@ichard26 ichard26 mentioned this pull request Jul 19, 2023
Closed
JukkaL
JukkaL approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JukkaL JukkaL merged commit 9f1c90a into python:master Feb 28, 2024
@ichard26 ichard26 deleted the local-final-names branch February 28, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lack of error message when a variable is annotated with Final without explicit type. urllib.request.urlopen results in AssertionError

2 participants

@ichard26 @JukkaL