KEMBAR78
[mypyc] Fix compilation of unreachable comprehensions by ichard26 · Pull Request #15721 · python/mypy · GitHub
Skip to content

Conversation

@ichard26
Copy link
Collaborator

Fixes mypyc/mypyc#816. Admittedly hacky.

@ichard26 ichard26 requested a review from JukkaL November 3, 2023 21:29
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is a kind of hacky, but it's still better than what we had before, and it's simple enough, so it doesn't seem too bad.

@JukkaL JukkaL merged commit f19b5d3 into python:master Feb 28, 2024
@ichard26 ichard26 deleted the fix-unreachable-comprehensions branch February 28, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unreachable generator expressions fails to compile

2 participants