KEMBAR78
Do not allow `TypedDict` classes with extra keywords by sobolevn · Pull Request #16438 · python/mypy · GitHub
Skip to content

Do not allow TypedDict classes with extra keywords #16438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2023
Merged

Do not allow TypedDict classes with extra keywords #16438

merged 3 commits into from
Nov 18, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 9, 2023

I think that sometimes metaclass= can still be used in real code, when people write compatibility layers with other metaclasses. I think that I've seen this a couple of times, but I cannot remember where and why.

In this case, this error can be precisely silenced.

AlexWaygood
AlexWaygood approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

This comment has been minimized.

Sign in to view
JelleZijlstra
JelleZijlstra reviewed Nov 9, 2023
View reviewed changes
@JelleZijlstra JelleZijlstra mentioned this pull request Nov 9, 2023
Closed
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@sobolevn
Copy link
Member Author

I realized that I want to reuse existing messages:

» mypy -c 'class A(a=1, b=2): ...'
<string>:1: error: Unexpected keyword argument "a" for "__init_subclass__" of "object"  [call-arg]
<string>:1: error: Unexpected keyword argument "b" for "__init_subclass__" of "object"  [call-arg]
Found 2 errors in 1 file (checked 1 source file)

JelleZijlstra
JelleZijlstra reviewed Nov 17, 2023
View reviewed changes
@sobolevn sobolevn changed the title Do not allow TypedDict classes with metaclass= Do not allow TypedDict classes with extra keywords Nov 17, 2023
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@JelleZijlstra JelleZijlstra merged commit 058f8fd into python:master Nov 18, 2023
@sobolevn sobolevn mentioned this pull request Nov 18, 2023
Closed
@QuLogic QuLogic mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

1 more reviewer

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @JelleZijlstra @AlexWaygood