Fix crash when overriding with unpacked TypedDict #17359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: ibis (https://github.com/ibis-project/ibis)
- ibis/backends/impala/__init__.py:760: error: Argument 2 of "drop_table" is incompatible with supertype "SQLBackend"; supertype defines the argument type as "tuple[str, str] | str | None" [override]
- ibis/backends/impala/__init__.py:760: note: This violates the Liskov substitution principle
- ibis/backends/impala/__init__.py:760: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
+ ibis/backends/impala/__init__.py:759: error: Signature of "drop_table" incompatible with supertype "SQLBackend" [override]
+ ibis/backends/impala/__init__.py:759: note: Superclass:
+ ibis/backends/impala/__init__.py:759: note: def drop_table(self, name: str, database: tuple[str, str] | str | None = ..., force: bool = ...) -> None
+ ibis/backends/impala/__init__.py:759: note: Subclass:
+ ibis/backends/impala/__init__.py:759: note: def drop_table(self, name: str, *, database: str | None = ..., force: bool = ...) -> None
- ibis/backends/clickhouse/__init__.py:513: error: Argument 2 of "create_database" is incompatible with supertype "CanCreateDatabase"; supertype defines the argument type as "str | None" [override]
- ibis/backends/clickhouse/__init__.py:513: note: This violates the Liskov substitution principle
- ibis/backends/clickhouse/__init__.py:513: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
- ibis/backends/clickhouse/__init__.py:513: error: Argument 3 of "create_database" is incompatible with supertype "CanCreateDatabase"; supertype defines the argument type as "bool" [override]
+ ibis/backends/clickhouse/__init__.py:512: error: Signature of "create_database" incompatible with supertype "CanCreateDatabase" [override]
+ ibis/backends/clickhouse/__init__.py:512: note: Superclass:
+ ibis/backends/clickhouse/__init__.py:512: note: def create_database(self, name: str, catalog: str | None = ..., force: bool = ...) -> None
+ ibis/backends/clickhouse/__init__.py:512: note: Subclass:
+ ibis/backends/clickhouse/__init__.py:512: note: def create_database(self, name: str, *, force: bool = ..., engine: str = ...) -> None
|
|
The second example in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17208
While writing the fix (that is trivial), I could not notice that the relevant code simply assumes functions can have nothing but positional parameters. This could lead really misleading error messages, so I decided to fix this as well.