KEMBAR78
Support `enum.member` for python3.11+ by sobolevn · Pull Request #17382 · python/mypy · GitHub
Skip to content

Support enum.member for python3.11+ #17382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2024
Merged

Support enum.member for python3.11+ #17382

merged 4 commits into from
Jun 14, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 14, 2024 •
edited
Loading

There are no tests for @enum.member used as a decorator, because I can only decorate classes and functions, which are not supported right now: https://mypy-play.net/?mypy=latest&python=3.12&gist=449ee8c12eba9f807cfc7832f1ea2c49

import enum

class A(enum.Enum):
    class x: ...

reveal_type(A.x)  # Revealed type is "def () -> __main__.A.x"

This issue is separate and rather complex, so I would prefer to solve it independently.

Refs #17376

@sobolevn sobolevn requested review from AlexWaygood and JukkaL June 14, 2024 07:04
AlexWaygood
AlexWaygood approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sobolevn @AlexWaygood
Update mypy/plugins/enums.py
f3f6a50 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

JukkaL
JukkaL approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@JukkaL JukkaL merged commit dac88f3 into master Jun 14, 2024
@JukkaL JukkaL deleted the issue-12841-member branch June 14, 2024 14:35
@ngnpope ngnpope mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

+1 more reviewer

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @JukkaL @AlexWaygood